Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'type' arg for antctl get bgproutes to filter bgproutes #6835

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Add 'type' arg for antctl get bgproutes to filter bgproutes #6835

merged 1 commit into from
Dec 4, 2024

Conversation

Atish-iaf
Copy link
Contributor

No description provided.

@Atish-iaf Atish-iaf added area/component/antctl Issues or PRs releated to the command line interface component area/transit/bgp Issues or PRs related to BGP support. labels Nov 27, 2024
@Atish-iaf Atish-iaf marked this pull request as ready for review November 27, 2024 09:32
@Atish-iaf Atish-iaf requested a review from antoninbas November 27, 2024 13:04
@Atish-iaf Atish-iaf force-pushed the add-type-arg-for-antctl-get-bgproutes branch 2 times, most recently from c5a3ed6 to de3d86c Compare November 28, 2024 09:59
@Atish-iaf Atish-iaf requested a review from antoninbas November 28, 2024 10:08
@Atish-iaf Atish-iaf force-pushed the add-type-arg-for-antctl-get-bgproutes branch from de3d86c to 2f96853 Compare November 29, 2024 04:51
antoninbas
antoninbas reviewed Dec 2, 2024
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only small comments, otherwise lgtm

pkg/agent/apiserver/handlers/bgppeer/handler.go Outdated Show resolved Hide resolved
pkg/agent/apiserver/handlers/bgproute/handler.go Outdated Show resolved Hide resolved
pkg/agent/apiserver/handlers/bgproute/handler_test.go Outdated Show resolved Hide resolved
@Atish-iaf
Add 'type' arg for antctl get bgproutes to filter bgproutes
7d5f79b 
Also, move all filtering logic from controller to handler for consistency.

Signed-off-by: Kumar Atish <[email protected]>
@Atish-iaf Atish-iaf force-pushed the add-type-arg-for-antctl-get-bgproutes branch from 2f96853 to 7d5f79b Compare December 3, 2024 06:42
@Atish-iaf Atish-iaf requested a review from antoninbas December 3, 2024 07:25
@Atish-iaf Atish-iaf added the action/release-note Indicates a PR that should be included in release notes. label Dec 3, 2024
@Atish-iaf Atish-iaf added this to the Antrea v2.3 release milestone Dec 3, 2024
@Atish-iaf
Copy link
Contributor Author

/test-e2e

@antoninbas antoninbas merged commit 773fb32 into antrea-io:main Dec 4, 2024
55 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoninbas antoninbas antoninbas approved these changes

Assignees
No one assigned
Labels
action/release-note Indicates a PR that should be included in release notes. area/component/antctl Issues or PRs releated to the command line interface component area/transit/bgp Issues or PRs related to BGP support.
Projects
None yet
Milestone
Antrea v2.3 release
Development

Successfully merging this pull request may close these issues.
2 participants
@Atish-iaf @antoninbas